feat: add AccountTreeController
#5847
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AccountGroupController
PatrykLucka
force-pushed
the
feat/account-group-controller
branch
from
56bec57 to
e96d94e
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
commented
May 26, 2025
packages/account-group-controller/src/AccountGroupController.test.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.test.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.test.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.test.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.test.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.test.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
ccharly
commented
May 26, 2025
Comment on lines
44
to
55
| accountGroups: { | ||
| groups: { | ||
| // Wallet | ||
| [accountGroup: AccountGroupId]: { | ||
| // Multichain Account OR Account Group | ||
| [accountSubGroup: AccountGroupId]: AccountId[]; // Blockchain Accounts | ||
| }; | ||
| }; | ||
| }; | ||
| accountGroupsMetadata: { | ||
| [accountGroup: AccountGroupId]: AccountGroupMetadata; | ||
| }; |
There was a problem hiding this comment.
From a sync with @danroc @gantunesr:
We could use this state instead:
- Better locality with
metadata - We would still persist everything (mainly because of the
metadata) - We should probably rename this controller to
AccountWalletController - We would have another
MultichainAccountController(stateless) that would abstract high-level multichain accounts methods/capabilities on top of this controller for multichain accounts support
Suggested change
| accountGroups: { | |
| groups: { | |
| // Wallet | |
| [accountGroup: AccountGroupId]: { | |
| // Multichain Account OR Account Group | |
| [accountSubGroup: AccountGroupId]: AccountId[]; // Blockchain Accounts | |
| }; | |
| }; | |
| }; | |
| accountGroupsMetadata: { | |
| [accountGroup: AccountGroupId]: AccountGroupMetadata; | |
| }; | |
| accountWallets: { | |
| // Wallet | |
| [accountWallet: AccountWalletId]: { | |
| // Multichain Account OR Account Group | |
| groups: [accountGroup: AccountGroupId]: { | |
| accounts: AccountId[]; // Blockchain Accounts | |
| metadata: Metadata; | |
| }, | |
| metadata: Metadata; | |
| }; | |
| }; |
@PatrykLucka WDYT?
There was a problem hiding this comment.
can you share a quick draft of what would be the use cases the MultichainAccountController should be responsible for? I'm concerned about the over complexity that is being introduced around all the controllers that will manage accounts to their own extend and the still present accounts legacy code.
it does not need to be a new ADR, just a quick notion page will be enough to start setting the limits of each controller and how they interact between each other
gantunesr
reviewed
May 27, 2025
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
Comment on lines
44
to
55
| accountGroups: { | ||
| groups: { | ||
| // Wallet | ||
| [accountGroup: AccountGroupId]: { | ||
| // Multichain Account OR Account Group | ||
| [accountSubGroup: AccountGroupId]: AccountId[]; // Blockchain Accounts | ||
| }; | ||
| }; | ||
| }; | ||
| accountGroupsMetadata: { | ||
| [accountGroup: AccountGroupId]: AccountGroupMetadata; | ||
| }; |
There was a problem hiding this comment.
can you share a quick draft of what would be the use cases the MultichainAccountController should be responsible for? I'm concerned about the over complexity that is being introduced around all the controllers that will manage accounts to their own extend and the still present accounts legacy code.
it does not need to be a new ADR, just a quick notion page will be enough to start setting the limits of each controller and how they interact between each other
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
packages/account-group-controller/src/AccountGroupController.ts
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| const accountGroupsMetadata = this.#generateUniqueGroupNames(groups); |
There was a problem hiding this comment.
will this method be re-executed for each new account?
There was a problem hiding this comment.
I think so, we need to update groups every time to have accounts list up to date, so the group names will be regenerated for now. We might want to add separate update functions, one only updating accounts (so no changes to groups or their name needed) and the other updating whole structure (ie. when new SRP is added)
PatrykLucka
force-pushed
the
feat/account-group-controller
branch
from
f740c42 to
63a0a51
Compare
ccharly
commented
May 27, 2025
packages/account-wallet-controller/src/AccountWalletController.ts
Outdated
Show resolved
Hide resolved
packages/account-wallet-controller/src/AccountWalletController.ts
Outdated
Show resolved
Hide resolved
packages/account-wallet-controller/src/AccountWalletController.ts
Outdated
Show resolved
Hide resolved
packages/account-wallet-controller/src/AccountWalletController.ts
Outdated
Show resolved
Hide resolved
packages/account-wallet-controller/src/AccountWalletController.ts
Outdated
Show resolved
Hide resolved
packages/account-wallet-controller/src/AccountWalletController.ts
Outdated
Show resolved
Hide resolved
…ount wallet naming
…eyring when entropy source is unknown
…controller) when naming keyring rule matches
ccharly
changed the title
AccountGroupControllerAccountWalletController
ccharly
changed the title
AccountWalletControllerAccountWalletController
ccharly
force-pushed
the
feat/account-group-controller
branch
from
c5fe946 to
7f2c281
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
changed the title
AccountWalletControllerAccountTreeController
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
New controller to group accounts based on some pre-defined rules.
References
Changelog
N/A
Checklist